https://bugs.documentfoundation.org/show_bug.cgi?id=89829

Yousuf Philips (jay) <philip...@hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |c...@nouenoff.nl,
                   |                            |philip...@hotmail.com,
                   |                            |tietze.he...@gmail.com,
                   |                            |vstuart.fo...@utsa.edu
           See Also|                            |https://bugs.documentfounda
                   |                            |tion.org/show_bug.cgi?id=85
                   |                            |131
             Blocks|                            |102946
     Ever confirmed|0                           |1

--- Comment #3 from Yousuf Philips (jay) <philip...@hotmail.com> ---
(In reply to mahfiaz from comment #0)
> 1) Mark a few words with a character style
> 2) Select one word, change its color to e.g red
> 3) while word still selected update the character style (one would have to
> have character styles open in styles and formatting dialog and pick "update
> style" from the rightmost button in the dialog)
> 4) select another word, change its color to e.g blue
> 5) repeat 3
> 6) see that the first word is still red, since the local formatting was not
> removed (which works just fine with paragraph styles)

In this case, where it is using the currently selected text to apply the
formatting to the rest of text, it should remove the direct formatting, just
like it does for the updation of paragraph styles.

> On the other hand this might be a pandora box and open another can of bugs,
> as how it should behave when the whole word is marked red, but when updating
> the character style only two letters are selected or even none at all.
> Should it expand the selection before removing properties? What if there are
> nonmatching regions, e.g
> <b>this is <selection>bold <i>this</selection> is bold italic</b> this is
> italic</i>
> Right now it would only update to bold, as the whole selection happens to be
> bold, but not whole it is italic.

Yes this issue needs some deep thought and research to find out what the best
default option should be and likely we should have option dialog options to
tweak its behavior to user preference, like

1) Clear all direct formatting on character styled text when updating style

from <charstyle><b>this is <i>some <u>text</i> and</u> some more<b></charstyle>
to <charstyle>this is some text and some more</charstyle>

2) Clear direct formatting that covers the entire text when updating style

from <charstyle><b>this is <i>some <u>text</i> and</u> some more<b></charstyle>
to <charstyle>this is <i>some <u>text</i> and</u> some more</charstyle>

3) Dont remove direct formatting when updating style (what we do now)

This issue is related to bug 85131 which talks about similar updation problems
with paragraph styles.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102946
[Bug 102946] [META] Styles bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to