https://bugs.documentfoundation.org/show_bug.cgi?id=103158
[email protected] changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]
--- Comment #9 from [email protected] ---
Created attachment 128113
--> https://bugs.documentfoundation.org/attachment.cgi?id=128113&action=edit
Revert part of tdf#92630
Hello, I reported the bug referenced here - tdf#96739.
It is for "ctrl+shift does not work at all", and so is the commit
mentioned.
as per comment #6 of said bug, the offending commit is:
74407aef94b6d8dfdd69891c4a6e578587ef3e71 (tdf#92630)
the check removed in commit 74407aef94b6d8dfdd69891c4a6e578587ef3e71
(tdf#92630)
- // send modkey events only if useful data is available
- if( pEvent->mnModKeyCode != 0 )
in core/vcl/unx/generic/window/salframe.cxx:3040-3050 we can see
that mnModKeyCode is only non-zero if( pEvent->type == KeyRelease ...
this ensured that the send is only for keyrelease, which caused this
regression.
while here, write a better comment for the reasoning for the check.
I'm fairly confident this will help, so I am sending it without checking.
Sorry for that - it will take me a very long time to confirm it is correct on
my slow hardware.
--
You are receiving this mail because:
You are the assignee for the bug._______________________________________________
Libreoffice-bugs mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
