https://bugs.documentfoundation.org/show_bug.cgi?id=104088
Katarina Behrens (CIB) <katarina.behr...@cib.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|needsDevEval, topicUI |
--- Comment #8 from Katarina Behrens (CIB) <katarina.behr...@cib.de> ---
First, not every change is an (incompatible) API change. Deleting a command is
an API change. Changing the type and number of arguments a command accepts is
an API change. However, changing return value of a command (which is what would
be required to make this .uno command a binary toggle) is NOT an API change,
thus it's fine to do it that way
Second, the code pointers are slightly misleading and rather incomplete. The
return value of SID_INSERT_PAGE_NUMBER slot is defined in sd/sdi/sdraw.sdi, it
should be changed from SfxVoidItem to SfxBoolItem. Then, a new case has to be
added to sd/source/ui/view/drviews3.cxx, DrawViewShell::ExecCtrl to serve the
changed slot. It has to contain some code to find out if the current page has a
page number visible and toggle it on/off
Come to think of it, maybe it'd be better to do this in a new, separate slot
(.uno:TogglePageNumber?) instead of sodomizing the old .uno:InsertPageNumber
one
And finally third, given all of the above, this is likely not an easy hack.
--
You are receiving this mail because:
You are the assignee for the bug._______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
