https://bugs.documentfoundation.org/show_bug.cgi?id=103825
--- Comment #9 from Pranav Kant <[email protected]> ---
(In reply to Aleksander Machniak from comment #8)
> I just saw "access_token_ttl must be a unix timestamp of when token will
> expire" in the above commit. This is not really true as for WOPI it is a
> number of milliseconds (not seconds) since 1970-01-01.
Yes, it is the number of milliseconds actually, ignore the commit message then
- it is incorrect.
>
> Also, the hardcoded 15 minutes time is well, not what I'd expect. I can
> imagine implementations with small session lifetime.
> E.g. PHP's default is
> 24 minutes. So, maybe it should be something like min("15 minutes",
> (ttl-now)/2).
Oh, didn't know that.
>
> Finally, as I really want to prevent from displaying this warning to the
> user, I hope you'll implement a way to reset the token and timer with
> postMessage API.
Yes, pushing a safe solution just before the release with minimum changes in
the code, surely will pick it up after the release.
--
You are receiving this mail because:
You are the assignee for the bug._______________________________________________
Libreoffice-bugs mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
