https://bugs.freedesktop.org/show_bug.cgi?id=48549
--- Comment #4 from Thomas Arnhold <[email protected]> 2012-07-19 13:11:49 PDT --- Hi Meko, nice work! Looks good to me. Here are some unused parameters: vcl/source/window/menu.cxx: The definition of nKeyCode is now unused (above your removal). So this else branch could go. basctl/source/basicide/baside2.cxx: sal_Bool bRemoved = pLayout->GetWatchWindow().RemoveSelectedWatch(); only call for pLayout->GetWatchWindow().RemoveSelectedWatch(); without saving it, as bRemoved would be unused. A question comes in mind: At some points the beep should say "here's an error". I've seen at least two points, where a debug message with OSL_FAIL() followed (sc/source/core/data/documen4.cxx). I think we should convert the beeps to debug messages at such points. Meko, what do you think? Maybe a post to the mailing list would be a good idea. Thomas -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
