https://bugs.documentfoundation.org/show_bug.cgi?id=112373

            Bug ID: 112373
           Summary: cleanup SpellChecker
           Product: LibreOffice
           Version: 5.3.3.1 rc
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: medium
         Component: Linguistic
          Assignee: libreoffice-bugs@lists.freedesktop.org
          Reporter: michael.me...@collabora.com

The SpellChecker class:

lingucomponent/source/spell/sspellimp.hxx / .cxx

has this:

    Hunspell **                        m_aDicts;
    Locale *                           m_aDLocs;
    sal_Int32                          m_nNumDict;

Which looks like a mess to me; we should use std::vector<> for these instead;
and nice iterators.

We should prolly use a std::unique_ptr<> as well for the Hunspell objects - but
please do add some debug / check that the Hunspell objects are not created and
destroyed more frequently than before the re-factor.

Thanks ! =)

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to