https://bugs.documentfoundation.org/show_bug.cgi?id=114939
--- Comment #8 from JimF <[email protected]> ---
I am not able to write a review, but I too (as did Michael Stahl) would fail
the code review. The code is fine, BUT since this function is used in the ODF
encryption scheme, all files current users have saved that are encrypted would
become unreadable.
There probably needs to be another flag added to the CTX structure for sha1,
listing if the hash should be correct or buggy. Then when importing the file
and ODF needs decrypt, first try the passscode with proper SHA1. If the
checksum fails, then re-try but set the flag for 'buggy' SHA1. If that
succeeds, then process the file as normal. However on save, only use the
'proper' SHA1 functionality.
This will fix the 'bug', make your files compliant, and not cause any problems
for your existing customers.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
