https://bugs.freedesktop.org/show_bug.cgi?id=46480
Noel Power <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|[email protected] |[email protected] | |desktop.org Component|Spreadsheet |Database --- Comment #19 from Noel Power <[email protected]> 2012-08-21 08:55:51 UTC --- (In reply to comment #17) > The cleanest (and maybe only "true") solution is to be clear as to when things > are escaped. > I see three solutions: > > - When lcl_getCondition is called, all values are already > SQL-encoded/escaped, > it should *never* encode/escape things again. > From looking at it for 5 minutes, this looks like the general design > of the stuff; it would be interesting to see why the encoding again > was added here in 3.4. see http://cgit.freedesktop.org/libreoffice/core/commit/?id=897ade45672a36ffd278b1cb9ba21694c0ee45c7 > > - When lcl_getCondition is called, nothing is SQL-encoded/escaped, > it should *always* encode/escape things. my gut feeling is that this the above is the case, it appears some effort ( in addition to the commit above ) was probably made at some stage to amalgamate the code in dbaccess and here ( of course I may be completely wrong ) and that that there remain some 'holes' in that rework > - If for some deep/weird reason none of the above is possible, > then some boolean flag that tells whether it should encode/escape. the uno api documentation ( since this stuff is triggered from the uno api ) didn't throw any light onto things for me. Looking at this again I *think* that the desired query result might be obtained by multiple calls to uno method 'appendFilterByColumn' which seems to it might more or less do the same thing as what DlgFilterCrit::BuildWherePart() is attempting to achieve. However at this stage I think I will respectfully bow out of this bug ( I only dropped by because it was a regression marked against spreadsheet ) Since I started looking I just continued but I am sorry I didn't really progress it much further. Although I can understand the what the code does I don't understand the why :-) I am woefully non-base enabled and feel I just lack to problem domain knowledge to make the calls here. I am reassigning to you Lionel, I am sure you will have the best idea for a solution. Thanks!! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
