https://bugs.documentfoundation.org/show_bug.cgi?id=119252
--- Comment #2 from Telesto <[email protected]> ---
Created attachment 144151
--> https://bugs.documentfoundation.org/attachment.cgi?id=144151&action=edit
Bibisect log
Bisected to
author Stephan Bergmann <[email protected]> 2018-02-01 15:12:26 +0100
committer Stephan Bergmann <[email protected]> 2018-02-01 20:52:11
+0100
commit 4a61006255c67bb6f9ac99107093a424a9de441e (patch)
tree 6101cafcacff9c688ceb6d8c13d29880cd0a6b38
parent 5357ca82846ea7147ad61e9340f25647a5934eb0 (diff)
Remove < USHRT_MAX check that is presumably no longer needed
The check was like this ever since 84a3db80b4fd66c6854b3135b5f69b61fd828e62
"initial import" (and SwRootFrame::mnBrowseWidth---which the nWidth here is
ultimately assigned to---was also of type long back then). But the only use
of SwRootFrame::mnBrowseWidth, in the call to SwRootFrame::GetBrowseWidth at
> long nWidth = GetUpper() ?
> static_cast<SwRootFrame*>(GetUpper())->GetBrowseWidth() : 0;
in SwPageFrame::MakeAll (sw/source/core/layout/calcmove.cxx), assigns it to a
long nWidth that doesn't appear to be used in a context where it needs to be
restricted to USHORT values (at least not any longer?), so assume that initial
check against USHRT_MAX-2000 is no longer needed.
https://cgit.freedesktop.org/libreoffice/core/commit/?id=4a61006255c67bb6f9ac99107093a424a9de441e
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
