https://bugs.documentfoundation.org/show_bug.cgi?id=120773
Lionel Elie Mamane <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever confirmed|0 |1
--- Comment #4 from Lionel Elie Mamane <[email protected]> ---
This comes from my commit
commit 2d73671e930a0099c26e268a2be417bfcdd7fc91
Author: Lionel Elie Mamane <[email protected]>
Date: Thu Oct 4 19:33:14 2018 +0200
clean up column pos vs column id
everywhere GetColumnAtXPosPixel is used;
see also tdf#119564 fix
Change-Id: Ibab57c7305bf4dce9ea9f3df66e6214b0d1585b2
You'll notice that around line 1240-1245, I changed:
nCol = GetColumnAtXPosPixel(rEvt.maPosPixel.X());
to
nCol = GetColumnId(GetColumnAtXPosPixel(rEvt.maPosPixel.X()));
So, the discussed line was created by search/replace of "GetColumnId(nCol)" by
"nCol" :)
Just remove the last (duplicate) || clause. The whole thing is safe because
GetColumnId(BROWSER_INVALIDID) == BROWSER_INVALIDID (see
svtools/source/brwbox/brwbox2.cxx around line 375), so for any x:
x == BROWSER_INVALIDID implies GetColumnId(x) == BROWSER_INVALIDID
and in particular
x == BROWSER_INVALIDID || GetColumnId(x) == BROWSER_INVALIDID
is equivalent to
GetColumnId(x) == BROWSER_INVALIDID
Here, x is the old value of nCol (before my patch), namely
GetColumnAtXPosPixel(rEvt.maPosPixel.X())
--
You are receiving this mail because:
You are the assignee for the bug._______________________________________________
Libreoffice-bugs mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
