https://bugs.documentfoundation.org/show_bug.cgi?id=50916
--- Comment #69 from Bartosz <gan...@poczta.onet.pl> ---
Some useful information for developers which would like to continue working on
this topic:
The very basic classes involved are : ScDocument - which represents the
document, ScTable - which represents a sheet, ScColumn - represents a single
column.
With below patches Dennis made a dynamic column container class called
ScColContainer which represents the dynamic column container and this container
gets instantiated in ScTable class as member aCol. Previously ScTable was
having a static array of ScColumn's of size 1024.
The list of Dennis patches which created dynamic column container and further
code refactoring is below in chronological order :
1. https://gerrit.libreoffice.org/21620 [ This is where the dynamic container
got created but still uses fixed number of columns to initialize the
datastructure. We can change this only after making changes to all places where
columns are accessed like aCol[nColIdx].someMethod() or similar because in all
these places it is assumed that there are always MAXCOL columns are available]
2. https://gerrit.libreoffice.org/22163 [ Refactors ScMarkData (to hold user
selection) and supporting classes to work efficiently with dynamic column
container ]
3. https://gerrit.libreoffice.org/27828 [ Addresses some issues with
ScAttrArray class(stores the attributes like background color, number format
etc..) when dynamic column container is used. This is discussed in the above
mentioned mailing list thread ]
4. https://gerrit.libreoffice.org/31125 [ Changes all places in table1.cxx
where there is naive column access to work correctly with the new dynamic
column container We next need to complete the refactoring of table1.cxx and
other files where column access is made which assumes there are MAXCOL
columns.]
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
