https://bugs.freedesktop.org/show_bug.cgi?id=49350
--- Comment #34 from tommy27 <[email protected]> 2012-09-23 06:45:05 UTC --- (In reply to comment #33) > > No.. the actual problem is (or was) that the dialog makes its own copy of all > entries and afterwards it tries to synchronize its own copy with the main > structure (where the entries are stored and checked when you type) in a very > non-efficient way. -- snip -- that was crazy and explain the worsening performance once the autocorrect database becomes larger > I have changed this so I only store what has been deleted and added to the > list and now there is no need for synchronization at all. > Using this approach it takes about 12 sec. WOW... let me say that I would already be very happy with such time. This is already a drastic improvement from the 6 minutes and 10 seconds I experienced with "z" entries > when I change some entries (at the beginning or end). It > generally works but I have to test all scenarios and make some more > improvements to the code before I commit - so it may take some time. don't worry, take the time you need. I'm struggling with OOo/Lib autocorrect performance issues from years and I can wait. > It still takes too long to save to a file and I think that I know the reason. > I > think that every time a new entry is added, the acor file is written. Which > then means that when you add 10 entries, acor file is (re)written 10 times. I > am not yet sure about this but maybe you can test this. mmmhhh... I do not confirm this... from my tests it seems that the acor_.dat file is saved only when you hit OK (I monitored the "last modified" infos on file properties), not after each new added entry... did you actually see time difference when hitting OK after adding a single or multiple new entries? does it always take 12 seconds, regardless of the number of newly added items? P.S. if you have a home-made test build with your latest fixes, I'll be glad to beta test it as well -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
