https://bugs.freedesktop.org/show_bug.cgi?id=56131
David Tardon <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from David Tardon <[email protected]> --- (In reply to comment #0) > We currently download almost all 3rd party source tarballs even when they > are not used. > > One solution is to define tarball names as configure variables and define > them only when needed. This approach is already used for some extensions. It is also used for all gbuildified external modules. $ grep @ ooo.lst.in | wc -l 68 > > Another solution would be to improve the "download" script and support some > simple syntax in the "ooo.lst. module, e.g: > > 7376930b0d3f3d77a685d94c4a3acda8-STLport-4.5-0119.tar.gz if > @BUILD_STLPORT@ == "yes" I do not think this is a good idea. > > > I prefer the second solution because it is handy to have list of all 3rd > party modules in one place "ooo.lst.in" file. In addition, it is easier to > update the version in this short file. Finally, we should touch configure.in > only when we want to change the logic of the checks. It helps with > cherry-picking fixes for different LO releases. I agree that the "a variable set in configure.in" approach is not ideal, but at least it means the tarball name only needs to be changed in one place. In the previous state of affairs the name was hardcoded in ooo.lst.in _and_ in the module's makefile.mk (split into two parts--the upstream tarball name and the md5 hash). There is a third possible solution: to have all the download information directly in the external modules. My preferred format for that is 2 files for every tarball in a module: * <tarball>.md5 for the name and md5 (in fact, output of md5sum <tarball>) * <tarball>.url for source URL. This file should be optional for the default URL (http://dev-www.libreoffice.org/src). This would need a change to the tooling, of course, but I think it would be easier to use in the end. -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
