https://bugs.freedesktop.org/show_bug.cgi?id=53070
--- Comment #40 from David Tardon <[email protected]> --- (In reply to comment #39) > Can't connect to other ADO sources either, so it seems our whole ADO driver > is bust (the Access and Access 2007 "drivers" are just alternative names for > the ADO driver with a preconfigured 'magic' data source URL). > > This would need some love from a developer with a Windows build and/or a QA > person with a windows debug build. I'd love to see the equivalent of gdb's > "thread apply all bt full" at the moment of the freeze. > > I'd be very happy to cooperate with a LibO-on-Windows developer. > > > I've looked a bit at the log of changes in connectivity/source/drivers/ado. > What strikes me as weird is: > > Commit 8256eb0205fcddb79a67be13d6507b2653ff5e08 > Author: Matúš Kukan <[email protected]> 2012-04-07 14:09:40 > Committer: David Tardon <[email protected]> 2012-05-29 07:24:43 > > connectivity: remove unused adabas files > > REMOVES files: > > connectivity/source/drivers/ado/AKeyColumn.cxx > connectivity/source/drivers/ado/AKeyColumns.cxx It is not weird at all, actually. git log says these files had never been compiled. > > > Commit fc6d226a0ed0e493a33d5f82edcedec0ddd37ec7 > Author: David Tardon <[email protected]> 2012-03-10 19:00:43 > Committer: David Tardon <[email protected]> 2012-03-12 08:53:56 > > WaE: missing braces around initializer for 'unsigned char [8]' > > ------------------ connectivity/source/drivers/ado/adoimp.cxx > ------------------ > index 14f5f52..3c05419 100644 > @@ -41,7 +41,7 @@ using namespace com::sun::star::sdbc; > using namespace com::sun::star::sdbcx; > > > -#define MYADOID(l) {l, 0,0x10,0x80,0,0,0xAA,0,0x6D,0x2E,0xA4}; > +#define MYADOID(l) {l, 0,0x10,{0x80,0,0,0xAA,0,0x6D,0x2E,0xA4}}; > > const CLSID ADOS::CLSID_ADOCONNECTION_21 = MYADOID(0x00000514); > const IID ADOS::IID_ADOCONNECTION_21 = MYADOID(0x00000550); > > > > Are we double-plus extra sure that this does not change the value of e.g. > ADOS::CLSID_ADOCONNECTION_21? Yes. Both CLSID and IID are typedef'd from GUID, which is declared as typedef struct _GUID { DWORD Data1; WORD Data2; WORD Data3; BYTE Data4[8]; } GUID; (http://msdn.microsoft.com/en-us/library/aa373931(VS.85).aspx). The commit just adds braces around the initializer for the Data4 array. -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
