https://bugs.freedesktop.org/show_bug.cgi?id=51023

--- Comment #58 from Tor Lillqvist <[email protected]> ---
Michael: The core surprising point that Lubos's patch wasn't aware of was that
all the drag-and-drop happens during the call to
pSlideSorterViewShell->StartDrag(); that returns only after the whole
drag-and-drop operation has finished.

For now, I fixed it in master by just reverting the patch for MacOSX only:

commit 192a0eb2beccee5349c3c7b60208aa95eb985f35
Author: Tor Lillqvist <[email protected]>
Date:   Wed Nov 7 15:50:21 2012 +0200

    fdo51023: Revert e4450c54aee85b295b933e91d207fd8220c01107 for Mac OS X

    See bug for discussion. Basically, the root cause to the problem is
    that on the Mac, all the drag-and-drop action happens during the call
    to pSlideSorterViewShell->StartDrag() in the Initialize method. Thus
    no wonder that mpDragAndDropContext is null in the ProcessDragEvent()
    as it has not been initialized yet, and is in fact initialised
    pointlessly only after the drag-and-drop already has finished.

    Reverted just for Mac OS X and ifdefified in a straightforward even if
    ugly fashion.

    Change-Id: Icfb62fb24a5c72fda39c8bcea125267c99ecf624

 .../controller/SlsSelectionFunction.cxx            |   42 ++++++++++++++++++++
 1 files changed, 42 insertions(+), 0 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to