https://bugs.documentfoundation.org/show_bug.cgi?id=128812
--- Comment #11 from Eike Rathke <er...@redhat.com> ---
(In reply to Julien Nabet from comment #7)
> A bit weird, isn't it?
Yeah looks a bit odd. A better approach probably would be to let places that
expect a single ScQueryEntry::Item in an ScQueryEntry already force that in a
strategic place (i.e. here in the ScQueryCellIterator ctor) and remove the
check and forcing 1 element from ScQueryEntry::GetQueryItem(), which would need
inspecting all places that use it first. Knowing that there is exactly one item
anyway the if (rItem.mbMatchEmpty...) could omit the extra check of
rEntry.GetQueryItems().size() == 1. Altogether eliminating two size() calls per
call that could squeeze those 3% of ScQueryCellIterator::GetThis().
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
