https://bugs.freedesktop.org/show_bug.cgi?id=56131
Petr Mladek <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected], | |[email protected] --- Comment #3 from Petr Mladek <[email protected]> --- I see that Matúš has already made nice improvements. Thanks for it. I think that should not overengineer it :-) If we have <tarball>.md5, we could omit md5 from the tarball name. So<tarball> will be the really used tarball name and it will be the same as in the upstream project. Heh, I have newer understood why they added the md5 sum into the tarball names in the first place. IMHO, it was pretty non-standard solution and was not a big win. My view is that it might work the following way: + configuire.ac will has something like: BLABLA_TARBALL= if <we want a 3rd party tarball because of a feature> ; then BLABLA_TARBALL="blabla-<version>.tar.gz" fi AC_SUBST(BLABLA_TARBALL) + ooo.lst.in would include: @BLABLA_TARBALL@ + download would read ooo.lst and download only the defined tarballs get $BLABLA_TARBALL from a given URL (see below my idea about the URL) get $BLABLA_TARBALL.md5 from the same URL check md5 to make sure that the tarball is valid + finally, $BLABLA_TARBALL can be used also in the makefile that is responsible for building the 3rd-party module This way, we could use the original tarballs and need to define tarball names only once in configure.ac as suggested by David. Regarding the URL. I do not see much advantages of $BLABLA_TARBALL.url. We would need to have this file on the default location http://dev-www.libreoffice.org/src. But I think that the main reason to use another location is because people do not have access to the default location. For example, KAMI has his extesnions on the OxygenOffice site. If people are able to upload $BLABLA_TARBAL.url on the default location, they could put there the tarball as well. I think that we should have all tarballs under our control on the default location anyway. So, we either need to move all tarballs to the default location or keep the URLs in ooo.lst. BTW: It would be nice to rename the file ooo.lst to download.lst or so. -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
