https://bugs.freedesktop.org/show_bug.cgi?id=56007
Michael Stahl <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Summary|Thumbnail generation slow |Explorer shell extension: |on network drives |Thumbnail generation slow | |on network drives --- Comment #5 from Michael Stahl <[email protected]> --- i'm not sure if that is a bug in the zip code or in that network file system; does the sread() not use a buffer somewhere? but it looks like it improves the code in any case with the new readString replacing numerous loops, and better error handling is also nice. there is a copy/paste error, 2 in readInt should be 4: + if (numBytesRead != 2) + throw IOException(-1); hmm... this looks like it wants to initialize a pointer with the size value? that cannot end well... perhaps better to create a real "string" with a specified size and read into that, if that is possible... + unsigned char *tmpBuf(size); it appears to me that your patch only works with one endian-ness, but given that this is win32 only code and windows only works in one endian-ness anyway that is without practical relevance. could you please send a mail with a text like http://permalink.gmane.org/gmane.comp.documentfoundation.libreoffice.devel/38402 to the mailing list [email protected] ? also best to send the patch either to mailing list or to gerrit (http://wiki.documentfoundation.org/Development/gerrit) because developers look there far more often than at bugzilla for patches. -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
