https://bugs.freedesktop.org/show_bug.cgi?id=57950
--- Comment #7 from Stephan Bergmann <[email protected]> --- ActivityChooserModel.java: The changes discussed here only work in C++ code, not in Java code. bastype3.cxx: You can simplify this even further by dropping the useless OUStringBuffer. Either make aName an OUString (and drop the makeSkingAndClear call from the return statement), or just build the string directly in the return statement. bastype.cxx, javatype.cxx: Same as above. dbfld.cxx: Some of the (performance) benefits are lost when you split the concatenation into multiple operator+= (instead of operator+) expressions. (Also, please take care to not indent with tabs. Tab widths are not universal, which makes the code easily look oddly indented. Your editor might be able to help you with avoiding tabs.) docexport.cxx and ww8graf.cxx look great already. RDFaExportHelper.cxx: s_prefix is defined as static const char s_prefix[] = "_:b" at the top of that file, but only used here. I would thus remove the definition of s_prefix and directly use the "_:b" string literal here -- which also makes it obvious that it is OK to drop the call of appendAscii, which in general is only OK if the argument to appendAscii was a string literal, not an arbitrary expression of pointer type. (Also see the tabs-vs.-spaces note above.) -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
