https://bugs.documentfoundation.org/show_bug.cgi?id=132172
Jan-Marek Glogowski <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever confirmed|0 |1
--- Comment #7 from Jan-Marek Glogowski <[email protected]> ---
So I did a bibisect in the 6.4 repo and the bug was introduced by
commit adbd20017ba9ac4cb2e20195f715904d9b11bc17
Author: Jan-Marek Glogowski <[email protected]>
Date: Mon Nov 25 14:08:44 2019 +0000
tdf#126607 Qt5 activate window before setFocus
On master it was later "fixed" by
commit 3afc718eddcd81232392d46fccc24b8ec626c8df
Author: Caolán McNamara <[email protected]>
Date: Tue Jan 14 10:06:30 2020 +0000
rework PageSizePopup to be a PopupWindowController
So I can just conclude, that the focus handling in the Qt5 VCL is still wrong
:-(
I originally changed
else if ((nFlags & SalFrameToTop::GrabFocus) || (nFlags &
SalFrameToTop::GrabFocusOnly))
- m_pQWidget->setFocus();
+ {
+ pWidget->activateWindow();
+ pWidget->setFocus();
+ }
but maybe the correct focus handling should be:
else if ((nFlags & SalFrameToTop::GrabFocus) || (nFlags &
SalFrameToTop::GrabFocusOnly))
{
- pWidget->activateWindow();
+ if (!(nFlags & SalFrameToTop::GrabFocusOnly))
+ pWidget->activateWindow();
pWidget->setFocus();
}
Problem is, I can't currently test this on master, because the "fix" is not
revertable. And the original bug 126607 doesn't happen anymore, because it
seems like the search toolbar isn't detachable anymore.
Guess I have to free some 30GB for a new 6-4 build to test my assumption...
--
You are receiving this mail because:
You are the assignee for the bug._______________________________________________
Libreoffice-bugs mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
