https://bugs.freedesktop.org/show_bug.cgi?id=60690
--- Comment #1 from Michael Meeks <[email protected]> --- Oh ! I forgot, we should also add a check for a recent(ish) version of gtk+ to our gtk2 plugin to ensure that we are not loaded on a truly ancient gtk+ that does not have the infrastructure needed for: gdk_threads_set_lock_functions We should also cleanup the horrible dlopening hackery that happens in: static bool hookLocks( oslModule pModule ) { typedef void (*GdkLockFn) (GCallback enter_fn, GCallback leave_fn); GdkLockFn gdk_threads_set_lock_functions = (GdkLockFn) osl_getAsciiFunctionSymbol( pModule, "gdk_threads_set_lock_functions" ); if ( !gdk_threads_set_lock_functions ) We should just directly link to gdk_threads_set_lock_functions instead :-) And while we include that we should use #if !GTK_CHECK_VERSION(2,2,0) // or whatever version it is # error "no lock hooking !" #endif to check that at compile time too. Thanks ! -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
