https://bugs.documentfoundation.org/show_bug.cgi?id=145117

--- Comment #11 from [email protected] ---
>So this issue may be fixed after we upgrade orcus to the <next version>

When I posted comment 4, I thought so, but I was wrong.

LibreOffice master has a patch already merged on April
https://gerrit.libreoffice.org/c/core/+/114892
, which is similar to the upstream so-called fix.
https://gitlab.com/orcus/orcus/-/commit/2c2215e94bd8fce4b9a93e986339aa6ae06d2cba

so I thought the bug was supposed to be fixed. I tested on latest master, and
unfortunately the bug was still reproducible.

I continued investigation on my own, and finally found the culprit as indicated
on comment 9.

--
sax_parser<_Handler,_Config>::element()
https://gitlab.com/orcus/orcus/-/blob/master/include/orcus/sax_parser.hpp#L225
calls

sax_parser<_Handler,_Config>::element_open(std::ptrdiff_t begin_pos)
at
https://gitlab.com/orcus/orcus/-/blob/master/include/orcus/sax_parser.hpp#L245
IF NO EXCEPTION IS THROWN,

https://gitlab.com/orcus/orcus/-/blob/master/include/orcus/sax_parser.hpp#L255

and then calls 
parser_base::element_name(parser_element& elem, std::ptrdiff_t begin_pos)
https://gitlab.com/orcus/orcus/-/blob/master/include/orcus/sax_parser.hpp#L255
https://gitlab.com/orcus/orcus/-/blob/master/src/parser/sax_parser_base.cpp#L394
,which calls

parser_base::name(std::string_view& str)
https://gitlab.com/orcus/orcus/-/blob/master/src/parser/sax_parser_base.cpp#L333
--

the patch mainly focuses on parser_base::name(std::string_view& str),
but the culprit is even before that. THE EXCEPTION WAS THORWN.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to