https://bugs.documentfoundation.org/show_bug.cgi?id=144853

--- Comment #5 from V Stuart Foote <vstuart.fo...@utsa.edu> ---
(In reply to Michael Warner from comment #4)
> (In reply to Heiko Tietze from comment #3)
> 
> >    + the ideal behavior would be as OP suggest, only change current word
> >      if no selection is done (Sascha)
> 
> If this is the decision then I submit that we should just skip applying
> sentence case formatting if cycling without selection, because applying
> sentence case only to the current word is equivalent to applying title case
> in this situation.

No, the cycle case is four distinct actions [1]. For consistency, with or
without selection must still be four states.  So, logic for Sentence case
without selection would need to apply at the word bound holding the cursor,
just as TITLE_CASE.

So, either test that we are in the cycle case loop--and modify the
SENTENCE_CASE handling, or fully remove the expanded run passed to the
SENTENCE_CASE transliteration [2].

Put another way, SENTENCE_CASE would *require* a selection (now trivial to make
at sentence bounds via mouse or keyboard) that would be honored exactly with no
expansion. Otherwise it would no longer expand beyond word holding text cursor
and behave like TITLE_CASE.

Probably simpler to do the later.

The Format -> Text -> Sentence case would be minimally effected--maybe adjust
do nothing with out a selection.  While the cycle case mode would gain
consistency (with or without selection), the main complaint.

=-ref-=
[1]
https://opengrok.libreoffice.org/xref/core/unotools/source/i18n/caserotate.cxx?r=84f8e28d#25
[2]
https://opengrok.libreoffice.org/xref/core/editeng/source/editeng/impedit4.cxx?r=6af0da48#2774

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to