https://bugs.documentfoundation.org/show_bug.cgi?id=82984
Ming Hua <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #19 from Ming Hua <[email protected]> --- (In reply to Kevin Suo from comment #18) > According to https://users.cs.jmu.edu/buchhofp/forensics/formats/pkzip.html: > > 1. The first 4 bytes, "504b 0304" indicates that it is a zip file. > 2. Bytes 19-22 denotes to "Compressed size". If archive is in ZIP64 format, > then this is "ffff ffff". > 3. Bytes 23-26 denotes to "Uncompressed size". If archive is in ZIP 64 > format, then this is also "ffff ffff". I don't think reading zip file headers is necessary, as it seems to be already read in https://opengrok.libreoffice.org/xref/core/package/source/zipapi/ZipFile.cxx?r=d0a8d4a9#938 where nCompressedSize and nSize should correspond to the "Compressed size" and "Uncompressed size" above. (In reply to Kevin Suo from comment #16) > File bugs which should be marked as a duplicate of this bug, in debugging > the exception should be in: > https://opengrok.libreoffice.org/xref/core/package/source/zipapi/ZipFile. > cxx?r=d0a8d4a9#946 And here is tests if nCompressedSize or nSize is "0xffffffff" to see if Zip64 is needed, throwing exception if yes. -- You are receiving this mail because: You are the assignee for the bug.
