https://bugs.documentfoundation.org/show_bug.cgi?id=119470
Justin L <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.documentfounda | |tion.org/show_bug.cgi?id=14 | |5354 --- Comment #18 from Justin L <[email protected]> --- (In reply to Justin L from comment #17) > - if (mpOptions->IsPageSize()) > + if (mpOptions->IsPrinterPreferred()) { // Then scale everything to print on the page } IsPageSize == "Fit to Printable Page" Well, it is just wrong to "scale everything to page" just because we want to use the paper size from the printer. IsPrinterPreferred() == "Fit to Printable Page" or Impress Notes/handout/outline (but not slides) or "Distribute on multiple sheets of paper" or "Tile piece of paper with repeated slides" or isBooklet. The commit totally changed which Impress views preferred to use the printers suggested paper size. What should be happening in each of these cases? DRAW: document definition should always win out in general (so not IsPrinterPreferred). That is already true -exception: isbooklet / isTiled / isFitToPage would use the printer defined paper size. That is also already true. IMPRESS: -slides: page definition is basically irrelevant - for screen purposes and should be treated as "Fit to Printable Page", and thus should prefer printer size (not currently true but was true before comment 1). -handouts: should use master handout slide setting. (never was true - but I think it should.) -notes: should use master notes setting. (not currently true, but was true before comment 1) -outline: should prefer printer size. (is/was true) Proposed revert in http://gerrit.libreoffice.org/c/core/+/125751 -- You are receiving this mail because: You are the assignee for the bug.
