https://bugs.documentfoundation.org/show_bug.cgi?id=146078

--- Comment #8 from Telesto <[email protected]> ---
@Buovjaga
A hypothesis 
1. "sw: Improved document comparison based on RSIDs." introduced the broken
kerning
2. Khaled attempt 'some fix' to broken kerning. Which I he - probably - did
without knowledge of the true cause. It solved the wiggle at bug 146080. See
bug 52028 comment 26
3. "fdo#52028: sw: let text formatting ignore RSID in automatic styles"
introduced the true fix. However, the change that Khaled prior to that, might
now introduce the averse effect - broken kerning. 

author  Tzvetelina Tzeneva <[email protected]>       2011-12-22 17:27:32
+0100
committer       Cédric Bosdonnat <[email protected]>     2011-12-22
17:53:53 +0100
commit  062eaeffe7cb986255063bb9b0a5f3fb3fc8e34c (patch)
tree    0f065352d000a11131203cf6832354bde597ff50
parent  61329db01af7fd7c5915a4d81896d52fda7168db (diff)
sw: Improved document comparison based on RSIDs.

----
author  Khaled Hosny <[email protected]>    2013-05-23 09:34:27 +0200
committer       Khaled Hosny <[email protected]>    2013-05-23 09:50:46
+0200
commit  736adbb4687eaa6b6a7a350a6452df2eceaad960 (patch)
tree    349302bc147dd1317261093fc57f887a284d8e29
parent  62b74b6c21b0b30bbb5a2053dabff375273b0c8e (diff)
Fix left to right full justification
I was overloading ApplyDXArray() with a HarfBuzz specific implementation
because the GenericSalLayout one was screwing right to left kerning, but
it seems to have broken left to right full justifications. Since
mnXOffset was introduced a bit earlier to fix a similar issue, it can
now be used here as well to minimize the possible side effects.

Seems to work fine for both left to right and right to left text now,
but at least one of my Arabic tests is regressing, so might need some
tweaking.

-----
Bisected to:
author  Michael Stahl <[email protected]>       2013-06-15 21:25:27 +0200
committer       Michael Stahl <[email protected]>       2013-06-20 00:34:38
+0200
commit  6db39dbd7378351f6476f6db25eb7110c9cfb291 (patch)
tree    0f9321d40740e87e80d8ed05a7c7f474d5310afd
parent  e012f326c1c32c053304998a6826cb322f2c7728 (diff)
fdo#52028: sw: let text formatting ignore RSID in automatic styles

Me lacking a build environment (and setting it up costs a lot of time). Could
you possibly do a manual revert of 736adbb4687eaa6b6a7a350a6452df2eceaad960 and
see if things improve?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to