https://bugs.documentfoundation.org/show_bug.cgi?id=146150
--- Comment #6 from Hossein <[email protected]> --- (In reply to Mike Kaganski from comment #5) > (In reply to Shivam Jha from comment #4) > > equivalent uno command for slot:5410 is .uno:HelpMenu > > Does that mean I just have to replace > > xRootMenuEntry.setPropertyValue("CommandURL", "slot:5410"); with > > xRootMenuEntry.setPropertyValue("CommandURL", ".uno:HelpMenu"); ? Or the > > property name (The first parameter) will change if we want to use a uno > > command instead of the slot value? > > I don't know what Hossein thinks about it, but I would assume this to be > your homework. Generally any change needs testing if it works as intended, > so I'd assume that you run the code (maybe that would be the hardest part of > the hack), and check if it worked correctly before (it should not); then > test is simple replacement of value would fix it. @Mike: I agree with you. The assignee have to understand and test the changes before submitting them. I think this procedure would be good: 1. Understand what does this line of code does (or it was meant to do). + Wiki can help 2. Make sure this line of code works correctly. + Test it live with LibreOffice 3. Change it to something like blank to see if the functionality fails. + Change, build and test 4. Put the new code in place and make sure the functionality works again. + Change, build and test @Shivam: If you have 2 line to change, change and test both of them. See what is appropriate for each of these lines. -- You are receiving this mail because: You are the assignee for the bug.
