https://bugs.documentfoundation.org/show_bug.cgi?id=141652

Justin L <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.documentfounda
                   |                            |tion.org/show_bug.cgi?id=13
                   |                            |4210

--- Comment #4 from Justin L <[email protected]> ---
All of these import-only changes started with LO 7.1.1 in order to fix bug
134210. Since this is an export bug, probably it has just exposed something
else.

The order was initial addition of the entire problematic "if(bIsCustomShape)"
clause in commit 2c96bd26ec488d865370fe9d394e7c4e228e05ab on 2021-01-21
10:52:46.

Then it changed to if(bIsCustomShape &&
   ( aGraphCrop.Left != 0 || aGraphCrop.Right != 0 || aGraphCrop.Top != 0 ||
aGraphCrop.Bottom != 0)) in commit 7400372efb3d279225a966a355644d2a3e7d42c3 on
Feb 23 16:41:15 2021

and finally to "if(bIsCustomShape && bHasCropValues && bNeedCrop)" in comment
1's commit on 2021-03-03 13:19:08.


Export seems to be multiplying the crop component in the case of exporting a
FillBitmapName, but not if just FillBitmap as indicated in comment 2. 

The addition of FillBitmapName looks like a copy/paste from elsewhere in this
file (based on review history). I personally have no idea about shapes, so I
don't know why one version should be chosen over another. The easy fix here
seems to only use FillBitmap as was done in earlier versions of the patch
series.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to