https://bugs.freedesktop.org/show_bug.cgi?id=61725

Tor Lillqvist <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #1 from Tor Lillqvist <[email protected]> ---
Does that mean that ReportBuilder used to work only by luck then? Or that the
condition which I turned into an assert isn't so serious after all? Sigh, I
hate this OSL_ENSURE style of "asertions" that aren't actually then that
serious, or maybe they are, depending on the case. The code is full of such
crack. 

The *fact* is that in the Android port, some serious and randomish crashes I
had in an experimental app went away when I did some changes to the app code
and the "SolarMutex not locked" warning stopped being displayed. Of course it
is very easy to miss such a warning (among the tons of debug output), so the
best way to make sure it doesn't fire is to turn it into an actual assert()...
Then one *must* debug the actual location where the assertion fires and fix
whatever is wrong.

Anyway, sure, I am prepared to revert that commit (or make the assert() used on
non-traditional OSes only), but I would like to have the input from some expert
here, sberg perhaps?

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to