https://bugs.documentfoundation.org/show_bug.cgi?id=132591
Julien Nabet <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|[email protected] | --- Comment #18 from Julien Nabet <[email protected]> --- I tried to compare use of m_xWidthED and m_xHeightED and I'm pretty quite sure there are some errors in sw/source/ui/frmdlg/frmpage.cxx diff --git a/sw/source/ui/frmdlg/frmpage.cxx b/sw/source/ui/frmdlg/frmpage.cxx index 49999bb82586..22aa31f3ec16 100644 --- a/sw/source/ui/frmdlg/frmpage.cxx +++ b/sw/source/ui/frmdlg/frmpage.cxx @@ -1845,7 +1845,7 @@ void SwFramePage::RangeModifyHdl() m_xWidthED->set_max(m_xWidthED->NormalizePercent(nTmp), FieldUnit::TWIP); nTmp = std::min(nHeight * nMaxWidth / std::max(nWidth, SwTwips(1)), nMaxWidth); - m_xHeightED->set_max(m_xWidthED->NormalizePercent(nTmp), FieldUnit::TWIP); + m_xHeightED->set_max(m_xHeightED->NormalizePercent(nTmp), FieldUnit::TWIP); } else { @@ -2046,7 +2046,7 @@ IMPL_LINK_NOARG(SwFramePage, AutoWidthClickHdl, weld::Toggleable&, void) IMPL_LINK_NOARG(SwFramePage, AutoHeightClickHdl, weld::Toggleable&, void) { if (!IsInGraficMode()) - HandleAutoCB(m_xAutoHeightCB->get_active(), *m_xHeightFT, *m_xHeightAutoFT, *m_xWidthED->get()); + HandleAutoCB(m_xAutoHeightCB->get_active(), *m_xHeightFT, *m_xHeightAutoFT, *m_xHeightED->get()); } IMPL_LINK( SwFramePage, ModifyHdl, weld::MetricSpinButton&, rEdit, void ) @@ -2163,7 +2163,7 @@ void SwFramePage::Init(const SfxItemSet& rSet) SwFrameSize eSize = rSize.GetHeightSizeType(); bool bCheck = eSize != SwFrameSize::Fixed; m_xAutoHeightCB->set_active(bCheck); - HandleAutoCB( bCheck, *m_xHeightFT, *m_xHeightAutoFT, *m_xWidthED->get() ); + HandleAutoCB( bCheck, *m_xHeightFT, *m_xHeightAutoFT, *m_xHeightED->get() ); if( eSize == SwFrameSize::Variable ) m_xHeightED->set_value(m_xHeightED->get_min()); Also, this part seems a bit weird: 1842 if (aVal.bAutoHeight && (m_sDlgType == "PictureDialog" || m_sDlgType == "ObjectDialog")) 1843 { 1844 SwTwips nTmp = std::min(nWidth * nMaxHeight / std::max(nHeight, SwTwips(1)), nMaxHeight); 1845 m_xWidthED->set_max(m_xWidthED->NormalizePercent(nTmp), FieldUnit::TWIP); 1846 1847 nTmp = std::min(nHeight * nMaxWidth / std::max(nWidth, SwTwips(1)), nMaxWidth); 1848 m_xHeightED->set_max(m_xHeightED->NormalizePercent(nTmp), FieldUnit::TWIP); 1849 } Now I still don't find the link with "upper" property. => I give up and uncc myself. -- You are receiving this mail because: You are the assignee for the bug.
