https://bugs.documentfoundation.org/show_bug.cgi?id=148430
Bug ID: 148430
Summary: Use std functions instead of our own implementation
Product: LibreOffice
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Keywords: difficultyMedium, easyHack, skillCpp
Severity: normal
Priority: medium
Component: LibreOffice
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected]
Blocks: 143781
Historically, some functions including various mathematical functions were not
available in the early versions of C/C++. In order to use those functions
inside LibreOffice, these functions were implemented internally.
For an example, some (inverse) trigonometric and (inverse) hyperbolic functions
like asinh() and acosh() were not available in the early versions of C++ std.
Instead of our own implementation inside LibreOffice, we now can use
std::asinh() and std::acosh() from <cmath>, available since C++11:
https://en.cppreference.com/w/cpp/numeric/math/asinh
The underlying methods from <math.h> are available since C99:
https://en.cppreference.com/w/c/numeric/math/asinh
The reason provided in f70de5267d7d9b7b6946cd72fe26e91bb6ac8431 to provide an
internal implementation was that asinh() and acosh() were "part of the C99
standard, but not provided by some compilers". This was true at that time, but
is no longer the case as the methods are now well established.
Referenced Bugs:
https://bugs.documentfoundation.org/show_bug.cgi?id=143781
[Bug 143781] [META] Development- and code-related bug reports
--
You are receiving this mail because:
You are the assignee for the bug.
