https://bugs.documentfoundation.org/show_bug.cgi?id=148407

--- Comment #12 from Eyal Rozenberg <[email protected]> ---
(In reply to Michael Stahl (allotropia) from comment #10)
> * pasting the content takes a long time
>   - actually this seems rather unlikely to me

Opening a large .docx file takes a lot of time (for some definition of "a
lot"); so why would pasting from MS-Word, or from a browser viewing an
MS-Word-generated HTML file, not take a lot of time?

>   - theoretically it might be possible to cancel but likely not
>     worth the effort, and it would need a specific test case first

It is absolutely worth the effort. Take any testcase, run it on a weaker
computer and make the document N copies of itself, and you have testcase which
takes a long enough time.

> * it's complicated to layout
>   - in this case, there isn't any way to "cancel" because
>     the layouting starts after the content is fully pasted.

I'm not knowledgeable enough to doubt this, but it seems strange to me that LO
freezes until it layouts a huge document, without showing the user anything and
accepting user input. If that's the case, that needs to change, which would
also allow for supporting cancellation of the paste.

>   - in certain places it is already checked if an input event
>     is being received which interrupts the layouting; this
>     is already a kind of "cancel" although if the document view
>     displays content that hasn't finished layouting it doesn't help
>     (the main case where it helps is if you interact with a
>     different LO document than the one that's layouting)

so, it's not a "kind of cancel".

> 
> * it contains lots of hyperlinked images
>   - i think the images are loaded asynchronously, but if the layout
>     depends on the size of an image, it will probably block at
>     that point so it's only theoretically async...

Well, that would be a bug in itself. An assumption should be made about the
size, layout should proceed accordingly, and asynchronously the layout should
be updated with the actual size and content.

>   - possibly this could be changed to be more incremental although
>     that's a bit risky...

How so? I mean, other than how any work making something less-blocking is
slightly dangerous.

>   - also some sort of cache could perhaps help - i think there has
>     never been any caching at the HTTP level so it could download
>     e.g. the same list bullet image multiple times

Perhaps, but that's a separate issue. The user needs to be able to cancel a
paste.


By the way - if the "cancel" only affects the not-yet-processed /
not-yet-layed-out parts - that would be good enough, since one could then use
Undo to remove everything that was actually pasted.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to