https://bugs.freedesktop.org/show_bug.cgi?id=62248
Lionel Elie Mamane <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |EasyHack | |DifficultyInteresting | |SkillCpp Assignee|[email protected] |[email protected] | |desktop.org CC| |[email protected] --- Comment #1 from Lionel Elie Mamane <[email protected]> --- Code pointers: File reportdesign/source/filter/xml/xmlExport.cxx function ORptExport::exportGroupsExpressionAsFunction That's where the name is chosen. Need to make it unique somehow. Please choose a naming scheme that is predictable and stable. I mean: - the user that happens to know LibreOffice's implementation details knows what the function name is just from the grouping information - stable: does not change as long as the grouping information does not change Take care that in file reportdesign/source/filter/xml/xmlGroup.cxx function OXMLGroup::OXMLGroup parses back what ORptExport::exportGroupsExpressionAsFunction creates. You need to keep that in sync *but* take care of backwards compatibility! That code needs to be able to parse old files, that is what *old* versions of ORptExport::exportGroupsExpressionAsFunction were creating, as well as new files. Rather than piling up fragility in this parsing, you might want to actually take the occasion to clean up this mess by actually storing the values chosen by the user in the UI directly (in new attributes of the <group> node). See the introduction of sort-expression in commit 4178806bb010129f3b13b62825476666fe48ddcd to see what I mean. For backwards compatibility, if the new clean way is not present, fall back to parsing the group-expression attribute. -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
