https://bugs.documentfoundation.org/show_bug.cgi?id=146904

Julien Nabet <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |heiko.tietze@documentfounda
                   |                            |tion.org,
                   |                            |[email protected],
                   |                            |[email protected]

--- Comment #6 from Julien Nabet <[email protected]> ---
Jérôme: I tested your patch but on Draw, when trying to export in PNG, this
code isn't called.

I gave a try, after some research the patch would be:
diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
index 73b1acbe871d..6d02a96b984b 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
@@ -4570,7 +4570,7 @@
                   </info>
                 </maxInclusive>
               </constraints>
-              <value>6</value>
+              <value>9</value>
             </prop>
             <prop oor:name="Interlaced" oor:type="xs:int"
oor:nillable="false">
               <!-- UIHints: File  Export  Filetype  PNG-Portable Network


Perhaps we should also modify the Jérôme's code location (which must be used
somewhere) +
https://opengrok.libreoffice.org/xref/core/svtools/source/filter/exportdialog.cxx?r=d3849255#791

    791         case FORMAT_PNG :
    792         {
    793             // Compression 1..9
    794             mxPNGCompression->show();
    795             sal_Int32 nCompression =
mpFilterOptionsItem->ReadInt32("Compression", 6);
    796             if ( ( nCompression < 1 ) || ( nCompression > 9 ) )
    797                 nCompression = 6;
replace both "6" values by "9"
the goal would be to have a homogenous thing, not a "9" value by default in a
case, and a "6" value in other cases.


Now I don't know if it's the right value to put I just can tell that Gimp uses
"9" by default. Since it's the number 1 in open source world for raster images,
I would trust their judgment.
However seeing some comments in
https://bugs.documentfoundation.org/show_bug.cgi?id=147550, it seems some may
disagree.

Heiko/Xisco: any thoughts here?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to