https://bugs.documentfoundation.org/show_bug.cgi?id=148978
Julien Nabet <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |needsUXEval CC| |heiko.tietze@documentfounda | |tion.org, | |olivier.hallot@libreoffice. | |org, [email protected] --- Comment #2 from Julien Nabet <[email protected]> --- With this patch: diff --git a/sw/source/ui/envelp/label1.cxx b/sw/source/ui/envelp/label1.cxx index 6d34ea2132de..a3b62c3d4e81 100644 --- a/sw/source/ui/envelp/label1.cxx +++ b/sw/source/ui/envelp/label1.cxx @@ -81,11 +81,17 @@ void SwLabDlg::PageCreated(const OString &rId, SfxTabPage &rPage) static_cast<SwLabPage*>(&rPage)->SetDBManager(pDBManager); static_cast<SwLabPage*>(&rPage)->InitDatabaseBox(); } - else + else // TODO: if we are in "labels", can we go in !m_bLabel static_cast<SwLabPage*>(&rPage)->SetToBusinessCard(); } else if (rId == "options") m_pPrtPage = static_cast<SwLabPrtPage*>(&rPage); + else if (rId == "medium") + { + static_cast<SwLabPage*>(&rPage)->SetDBManager(pDBManager); + static_cast<SwLabPage*>(&rPage)->InitDatabaseBox(); + static_cast<SwLabPage*>(&rPage)->SetToBusinessCard(); + } } SwLabDlg::SwLabDlg(weld::Window* pParent, const SfxItemSet& rSet, @@ -275,7 +281,6 @@ void SwLabPage::SetToBusinessCard() m_xSheetButton->set_help_id(HID_BUSINESS_FMT_PAGE_SHEET); m_xMakeBox->set_help_id(HID_BUSINESS_FMT_PAGE_BRAND); m_xTypeBox->set_help_id(HID_BUSINESS_FMT_PAGE_TYPE); - m_xAddressFrame->hide(); }; IMPL_LINK_NOARG(SwLabPage, AddrHdl, weld::Toggleable&, void) - first tab "Medium" displays - the Database part (and shows the databases in list) - the label text and address checkbox - help goes to Medium part but it doesn't talk about label text and address checkbox AND doesn't talk about database part. So I think we need first to know what is expected here. For example why to call this tab "Medium" for "Business Card" and "Labels" for "Labels" if they must display the same thing? Of course whatever the decision, help should be modified. Heiko/Xisco: thought you might be interested in this one. -- You are receiving this mail because: You are the assignee for the bug.
