https://bugs.documentfoundation.org/show_bug.cgi?id=149519

Julien Nabet <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #7 from Julien Nabet <[email protected]> ---
Eike:
does this patch make sense?
diff --git a/sc/source/ui/view/cellsh2.cxx b/sc/source/ui/view/cellsh2.cxx
index bc9dc416b1d5..a0d3fd14b0de 100644
--- a/sc/source/ui/view/cellsh2.cxx
+++ b/sc/source/ui/view/cellsh2.cxx
@@ -392,7 +392,7 @@ void ScCellShell::ExecuteDB( SfxRequest& rReq )
                     else if( nCol > aSortParam.nCol2 )
                         nCol = aSortParam.nCol2;

-                    aSortParam.bHasHeader       = bHasHeader;
+                    aSortParam.bHasHeader       = aSortParam.bHasHeader ||
bHasHeader;
                     aSortParam.bByRow           = true;
                     aSortParam.bCaseSens        = false;
                     aSortParam.bNaturalSort     = false;


I mean, we got
388 bool bHasHeader = rDoc.HasColHeader( aSortParam.nCol1, aSortParam.nRow1,
aSortParam.nCol2, aSortParam.nRow2, nTab );
which tries to "guess" if there's a column header but if the checkbox "Range
contains column labels" is enabled, and it's the case by default, we should
keep this and use the result of bHasHeader only if disabled.
What do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to