https://bugs.documentfoundation.org/show_bug.cgi?id=141294

Aron Budea <aron.bu...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caol...@redhat.com
           Keywords|                            |bibisected, bisected,
                   |                            |regression

--- Comment #15 from Aron Budea <aron.bu...@gmail.com> ---
Indeed, the immediate problem seems to be that in this call the range is empty
(minimum is larger than maximum):
https://opengrok.libreoffice.org/xref/core/sfx2/source/sidebar/SidebarController.cxx?r=0ec2b93c#1436

A very simple hack would be to always correct the bounds to a valid range, but
that won't make it resizable.

Older changes that affected sidebar width on HiDPI screens are as follows,
tested on Windows 10 with 4K resolution and 250% scaling.

Before the following commit in 6.3, the distance between minimum and maximum
was fairly large. Afterwards, the minimum increased a lot, and the sidebar was
wide even at the minimum.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=a58391b1f61db702a5246c5a33717cbba68c5252
author          Samuel Mehrbrodt <samuel.mehrbr...@cib.de>      2019-03-22
16:17:11 +0100
committer       Samuel Mehrbrodt <samuel.mehrbr...@cib.de>      2019-03-25
16:19:13 +0100

"Related tdf#124263 Make sure sidebar is wide enough for content"

After the following commit in 7.2, both the minimum/maximum was reduced, and
the distance remained small between the two.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=84b512ab3d8007293f2e8d338814db3ce7e4a63e
author          Caolán McNamara <caol...@redhat.com>    2021-03-30 11:14:12
+0100
committer       Caolán McNamara <caol...@redhat.com>    2021-03-31 21:06:37
+0200

"tabbar is now too wide under windows hidpi"

Then the commit that triggers the resize loop for me is the following (in 7.2),
but I think only because it increases the calculated minimum width to be larger
than the (rather small) maximum.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=8fa4371664108560dda438be8fc997d9cfe4bb6e
author          Heiko Tietze <tietze.he...@gmail.com>   2021-05-07 12:19:19
+0200
committer       Heiko Tietze <heiko.tie...@documentfoundation.org>     
2021-05-11 16:10:45 +0200

"Resolves tdf#127406 - Font name and style name not readable"

Not sure what would be a consistent minimum/maximum width calculation that
equally applies to regular and HiDPI scaling.
Caolán, Samuel, do you have thoughts on this?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to