https://bugs.documentfoundation.org/show_bug.cgi?id=150302
Hossein <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |difficultyMedium, easyHack Whiteboard| |reviewed:2022 --- Comment #3 from Hossein <[email protected]> --- (In reply to Regina Henschel from comment #1) > The error is in case SID_FONTWORK_SAME_LETTER_HEIGHTS in impl_execute method > in > https://opengrok.libreoffice.org/xref/core/svx/source/toolbars/fontworkbar. > cxx?r=4c0b033e#242 > The else part is missing. > Since the icon has a .uno command, a unit test is possible using the > dispatcher. > > @Hossein: I think, this can be an EasyHack. Do you agree? Yes! And thanks for suggesting this issue for an EasyHack. I've tested your code pointer, and the fix is straightforward. On the other hand, I think it should be marked as difficultyMedium, because one needs to gain a basic understanding of ODF and the draw:text-path-same-letter-heights attribute and change it manually inside <draw:enhanced-geometry> to see its effect, then fix the code and write a test similar to some of those in sd/qa/unit/uiimpress.cxx. This is the related part of the ODF 1.3 standard for the above attribute: Open Document Format for Office Applications (OpenDocument) Version 1.3. Part 3: OpenDocument Schema OASIS Standard - 27 April 2021 19.224 draw:text-path-same-letter-heights https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part3-schema/OpenDocument-v1.3-os-part3-schema.html#__RefHeading__1417288_253892949 -- You are receiving this mail because: You are the assignee for the bug.
