[Libreoffice-bugs] [Bug 150177] macOS Wildly blinking cursor and non-visible selection issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150177

--- Comment #13 from will.brokenbourgh2...@gmail.com ---
Okay LO devs, it appears the issue is here:

vcl/osx/salframe.cxx on line 103 in function
AquaSalFrame::AquaSalFrame( SalFrame* pParent, SalFrameStyleFlags salFrameStyle
)

The code seems to just be blindly accepting whatever is in the defaults instead
of validating it.  I recommend adding sanity checks before assigning something
as important as the blink time.

(Sorry, don't know how to add code tags to these reports)

- - - - -
    mpParent = dynamic_cast<AquaSalFrame*>(pParent);

    initWindowAndView();

    SalData* pSalData = GetSalData();
    pSalData->mpInstance->insertFrame( this );
    NSUserDefaults *userDefaults = [NSUserDefaults standardUserDefaults];
    if (userDefaults != nil)
    {
        id setting = [userDefaults objectForKey:
@"NSTextInsertionPointBlinkPeriodOn"];
        if (setting)
            mnBlinkCursorDelay = [setting intValue];
        else
        {
            setting = [userDefaults objectForKey:
@"NSTextInsertionPointBlinkPeriodOff"];
            if (setting)
                mnBlinkCursorDelay = [setting intValue];
        }
    }
- - - - -

-- 
You are receiving this mail because:
You are the assignee for the bug.