https://bugs.freedesktop.org/show_bug.cgi?id=61688

--- Comment #13 from Terrence Enger <[email protected]> ---
The SIGABRT disappears with application of this patch against master
commit 51a18f9 (2013-03-14).

--- a/vcl/source/window/builder.cxx
+++ b/vcl/source/window/builder.cxx
@@ -1389,6 +1389,10 @@ void VclBuilder::handleTabChild(Window *pParent,
xmlreade
 //we sort these into a best-tab-order sequence
 bool VclBuilder::sortIntoBestTabTraversalOrder::operator()(const Window *pA,
co
 {
+    // STL requires that this function be irreflexive
+    if( pA == pB )
+        return false;
+
     //sort child order within parent list by grid position
     sal_Int32 nTopA = pA->get_grid_top_attach();
     sal_Int32 nTopB = pB->get_grid_top_attach();

This patch changes the the value in the case that pA and pB are the
same pointer and they point to a label widget.  In this, it partly
contradicts commit 16d7194e
<http://cgit.freedesktop.org/libreoffice/core/commit/?id=16d7194ee73786c212e8639d41c7c31735ca930a>.


@Caolan,

Can you point me to an instance of the problem that your commit fixed?
IIUC, the problem is that the tab key gets caught in a too-small loop.
I wonder if my patch brings back the old problem.

Any other comments or guidance is welcome, of course.

Thanks,
Terry,

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to