https://bugs.documentfoundation.org/show_bug.cgi?id=151539
Bug ID: 151539
Summary: The three Kodak Photo CD flavors look redundant
Product: LibreOffice
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: filters and storage
Assignee: [email protected]
Reporter: [email protected]
We have three filters for Kodak Photo CD (PCD) format:
* PCD - Kodak Photo CD (758x512)
* PCD - Kodak Photo CD (192x128)
* PCD - Kodak Photo CD (384x256)
They seem to be all using the same code GraphicFilter::readPCD [1], and that
only checks the value of Office.Common/Filter/Graphic/Import/PCD config, which
defines the resolution.
The config is written in SdFilterDetect::detect [2], where it relies on user's
explicit filter choice (because automatic detection, implemented in
GraphicFormatDetector::checkPCD [3], does nothing to detect resolution).
It seems that if this information is absent in the format, it could be better
served by using a filter options dialog with user choice for resolution, just
as with e.g. CSV or Text (Choose Encoding) filters. That would also decrease
number of import filters a bit in the huge list (see bug 151537; it is also
present in e.g. Insert Image dialog). The format shouldn't be of much use
nowadays, so having three entries in the list looks a bit too much :)
[1]
https://opengrok.libreoffice.org/xref/core/vcl/source/filter/graphicfilter.cxx?r=ca510d64#readPCD
[2]
https://opengrok.libreoffice.org/xref/core/sd/source/ui/unoidl/sddetect.cxx?r=2ab40e9e#51
[3]
https://opengrok.libreoffice.org/xref/core/vcl/source/filter/GraphicFormatDetector.cxx?r=8ad101aa#1032
--
You are receiving this mail because:
You are the assignee for the bug.
