https://bugs.documentfoundation.org/show_bug.cgi?id=145988

--- Comment #48 from Patrick Luby <[email protected]> ---
(In reply to خالد حسني from comment #46)
> I can reproduce this issue (it is actually been like this since I first
> built on macOS a few months ago, to the point I assumed it is some debug
> build thing).
> 
> There are lost of comments here, so I’m not sure what I can help with
> debugging this.

@خالد حسني

I cannot reproduce this bug on either my Intel or Silicon machines but I have a
theory: somewhere in the vcl code, Skia images are copied with the wrong
colorspace. Can you try building LibreOffice with the following patch?:

https://gerrit.libreoffice.org/c/core/+/144052

Do you still see the color shifting after rebuilding with the above patch?

>From what I could see, Skia stores pixels in 32 bit RGBA format whereas
LibreOffice uses 24 bit RGB pixels or 32 bit ARGB pixels. From the screen
snapshots attached to this bug, it appears that somewhere RGBA pixels in Skia
bitmaps are getting incorrecting converted to RGB or ARGB pixels. This might
explain why white pixels (#ffffff) turn yellow (#ffff00).

The patch removes the one colorspace change that I found by grokking for any
CGColorSpace and SkColorSpace functions and variables.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to