https://bugs.documentfoundation.org/show_bug.cgi?id=148071

--- Comment #3 from Sierk Bornemann <sie...@gmx.de> ---
LO's About window unfortunately still says "Mac OS X" rather than "macOS".

Version: 7.4.4.1 / LibreOffice Community
Build ID: 988f4a351a6fa8cf4bdf2bdc873ca12cf8cbe625
CPU threads: 10; OS: Mac OS X 13.1; UI render: default; VCL: osx
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

Version: 7.6.0.0.alpha0+ (AARCH64) / LibreOffice Community
Build ID: 8635c9aa8c6f1078a9e220076d5a08daf30077e8
CPU threads: 10; OS: Mac OS X 13.1; UI render: Skia/Metal; VCL: osx
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

My first guess has been, it comes from reading the ProductName key value of
/System/Library/CoreServices/SystemVersionCompat.plist
(<key>ProductName</key><string>Mac OS X</string>) rather than that in
/System/Library/CoreServices/SystemVersion.plist
(<key>ProductName</key><string>macOS</string>)?

Short explanation concerning these two files and which one to choose or to
prefer, see
https://eclecticlight.co/2020/08/13/macos-version-numbering-isnt-so-simple/,
section "Interpreted and JIT languages" and especially the last sentence of the
last paragraph of that section.


Correction: as I see in the patch by Julian Nabet, it seems to be a tiny
hardcoded string in /vcl/osx/salinst.cxx, line 890:
https://gerrit.libreoffice.org/c/core/+/131836/1/vcl/osx/salinst.cxx#b890

Following that all – maybe it would be better anyway, to determine and
extracting that info via the OS itself based on

/usr/sbin/system_profiler SPSoftwareDataType
resp.
/usr/sbin/system_profiler SPSoftwareDataType -detailLevel mini ?

or simpler getting it with

/usr/bin/sw_vers -productName
/usr/bin/sw_vers -productVersion

instead of hardcoding it per string?

BTW: /usr/bin/sw_vers seems to read
/System/Library/CoreServices/SystemVersion.plist, if I interpret its manpage
correctly.



@Rob, @Mike Kaganski, @Patrick Luby: maybe one of you to make a short and easy
patch & commit or at least commit Julien's patch proposal?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to