https://bugs.documentfoundation.org/show_bug.cgi?id=148071
--- Comment #7 from Sierk Bornemann <[email protected]> --- (In reply to Stephan Bergmann from comment #6) > (In reply to Sierk Bornemann from comment #5) > > Created attachment 184324 [details] > > Change about info Mac OS X to macOS > > Assuming this patch is about vcl/osx/salinst.cxx, I guess this change would > still suffer from the open issues discussed at > <https://gerrit.libreoffice.org/c/core/+/131836> "tdf#148071: change about > info Mac OS X to macOS"? I've read the comments carefully. And have tried to unterstand the code behind the functions in question. Answering your question, DOES it then really suffer from the open issues discussed in https://gerrit.libreoffice.org/c/core/+/131836 ? I mean and conclude: No. I think, it's unrelated, the feared *potentially* guessed side effects, untested because of lacking environment, would not come to action. As I read and understand the comments in question on gerrit: nobody has substantiated their reservations with corresponding code passages, because in each case apparently the right environment was missing to get it out, e.g. "Unfortunately, not sure how to get the right string out of Mac M1 architecture as I don't own one.". BTW: I have posted several ways above, how to get the right string. DO these speculated und guessed and NOT further investigated discussed potentially problems relate to THIS particulary issue in question? I guess, they have NOTHING in common with each other and DO NOT relate to each other, if I interprete the code correct – I think, the discussed *potentially* side effects are just what they are: pure fearing/guessing and without substance. Take https://help.libreoffice.org/latest/en-US/text/scalc/01/04060104.html#hd_id5787224 Where and how are these variables for Info("system") are hardwired? They very all look hardwired. There seems to be a MACOSX string anywhere, being a variable. Capitalized. Without space within. As in "#elif defined MACOSX". But this string, we talk about here is "Mac OS X" (and should be changed to "macOS"). Two different purposes, two different aims, two different locations in the code with nothing in common with each other. Further: I have no Microsoft Office installed on my Mac, so I can't answer the open question, what Microsoft Office throws as System Info string, so I don't know, if PushString("Windows (32-bit) NT 5.01") ist still appropriate in https://git.libreoffice.org/core/+/refs/heads/master/sc/source/core/tool/interpr5.cxx#3263 or should be another string for compatibility reasons, I guess, it should be another string, but I can't have a look, because I have no MS Office. But that is another construction site, unrelated to THIS bug/issue in question here. All reservations about changing the string "Mac OS X" to "macOS" in the about dialog, changing it dynamically via a system function, I see as speculation that cannot be substantiated on closer inspection. So, in my view, the string can be changed (and should use OS-supplied system functionality instead of hard-wiring it manually) without fear of negative side effects. Just my 2 cents. I'd be happy to be taught better. -- You are receiving this mail because: You are the assignee for the bug.
