https://bugs.freedesktop.org/show_bug.cgi?id=60690

--- Comment #7 from Michael Meeks <[email protected]> ---
Great - I pushed that. There is more cleanup potential here though ... so lets
not close this bug yet.

Incidentally - can you put fdo#60690 as the first word in your commit messages
so they are associated with here ? here is what else needs doing ;-)

These methods need killing:

    virtual int         Grab()          { return 0; };
    virtual void        Ungrab(int )    {};

And all their uses; which rather highlights the fact that "GTK_YIELD_GRAB" has
actually not done anything for ages - and we should remove all instances of
that macro, and all it's call sides.

It was an horrible fallback for the proper integrated locking that we could do
with the hook :-)

Thanks !

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to