https://bugs.documentfoundation.org/show_bug.cgi?id=83532

--- Comment #22 from Michael Stahl (allotropia) <[email protected]> 
---
probably this was fixed for Writer by:

but possibly the same bug is in EditEngine as used by Drawing Shapes/Calc/etc.


commit db115bec9254417ef7a3faf687478fe5424ab378
Author:     Michael Stahl <[email protected]>
AuthorDate: Tue Feb 14 18:03:55 2023 +0100
Commit:     Michael Stahl <[email protected]>
CommitDate: Fri Feb 24 07:32:23 2023 +0000

    tdf#78510 sw,cui: split SvxLRSpaceItem for SwTextNode, SwTextFormatColl

    Leave editengine and non-paragraph usages of SvxLRSpaceItem as-is for now.

    Add new items RES_MARGIN_LEFT etc., order them so that paragraphs can
    have 3 consecutive items RES_MARGIN_FIRSTLINE..RES_MARGIN_RIGHT and
    non-paragraphs also have 2-4 consecutive items
    RES_MARGIN_RIGHT..RES_MARGIN_LEFT (only the 3 paragraph ones are
    actually used now).

    The HTML import filter is particularly annoying because it parses CSS
    stuff into SfxItemSets without knowing where the items will be applied,
    so it can't know whether to create SvxLeftMarginItem or
    SvxTextLeftMarginItem... the split items are created in ParseCSS1_*
    functions and then converted later if necessary.

    WW8 import has some weird code as well, SwWW8ImplReader::Read_LR()
    creates 3 items and then something wants to set every item on its own
    so SwWW8FltControlStack::SetAttrInDoc() turned out rather weird.

    Convert the paragraph dialog to handle the split items (by mapping them
    to SID_ATTR_PARA_FIRSTLINESPACE/SID_ATTR_PARA_LEFTSPACE/
    SID_ATTR_PARA_RIGHTSPACE), but the SvxRuler looks a bit more confusing
    so convert in sw shells for now and leave that for later (also unclear if
    changing these slot items like SID_ATTR_PARA_LRSPACE breaks any ABIs?).

    Change-Id: I40431821868fd3e1cceba121b5539ff9ae6befbc
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147024

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to