https://bugs.documentfoundation.org/show_bug.cgi?id=123159
[email protected] changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|[email protected] |[email protected] |desktop.org | --- Comment #19 from [email protected] --- I'm a beginner developer and I am trying to implement this change following the strategy outlined above. I have a few questions about it. Since the name of the function is MouseButtonUp, it would seem related to a mouse functionality. Is that the right place to add the "CTRL+Enter" keyboard combination, or should I find a better place for it? Then, about the GetEditUrl function: > The mouse position there is only needed to obtain the URL from the cell via > ScGridWindow::GetEditUrl() and for the tiled rendering case. Separating that > out and factoring out all the address conversion then would only need a > GetEditUrl() on the currently active cell for the keyboard case. Should I just find a way to express the active cell without using the mouse and replace rMEvt.GetPosPixel() with that? And finally, about OpenURL: > For ScGlobal::OpenURL() it's about the active view shell/frame and mouse > click modifier keys. The view shell/frame is the same for a Ctrl+Enter (or > whatever) and whether to evaluate the mouse click modifier (and what happens > if not) could be made a parameter, defaulted to current behaviour. >From what I've seen OpenURL() takes two main arguments: aUrl and aTarget. They are both initialized as OUString without any values and used immediately in GetEditURL(). Where is the mouse click modifier? I don't understand that final part. -- You are receiving this mail because: You are the assignee for the bug.
