https://bugs.documentfoundation.org/show_bug.cgi?id=151833

--- Comment #11 from Noel Grandin <noelgran...@gmail.com> ---
Discussion from IRC:

<vmiklos> noelgrandin: sure, the bugdoc contains a KeepRatio setting and the
commit in question adds the import for it :) so the feature is simply lost
before, which means it's harder to see the breakage
<noelgrandin> aha!
<vmiklos> it's definitely a bug, i am just not sure it's a recent problem
<noelgrandin> hmm, probably if KeepRation==true, then the UI elements that
allow adjusting the relative width/height should be disabled?
<vmiklos> noelgrandin: KeepRatio assumes that one of the dimensions have a
value (percentage or fixed). so "keep ratio" for both width and height is
broken, but width=50% + keep ratio for height is OK
<vmiklos> since that 50% will be 50% of something, e.g. page width without
margins or so
<noelgrandin> vmiklos, keep ratio is a single setting, not one for each of
width height. So I still don't see how having KeepRatio=true __and__ having
both of Width and Height relative to something is legal - IMO that will
obviously lead to constraints that cannot be simultaneously satisfied
<vmiklos> noelgrandin: yes, you're right. if KeepRatio is true, then you should
only set either width or height and it's ideal if the UI enforces this

So basically, this document is broken - on import, we should either
(a) set KeepRatio to false
or
(b) Set one of the Width or Height to non-relative.

And we should enforce this in the UI, it should not be possible to set Width
and Height to relative, __and__ set KeepRatio to true.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to