[Libreoffice-bugs] [Bug 153704] Style Heading level label was gone in Chinese/Japanese/Korean interfaces

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153704

--- Comment #12 from Franklin Weng <frank...@goodhorse.idv.tw> ---
@Khaled 

in svx/source/styles/CommonStylePreviewRenderer.cxx  line 417

    auto aScript = aEditEngine.GetScriptType({ 0, 0, 0, 0 });
    for (sal_Int32 i = 1; i <= maScriptText.getLength(); i++)
    {
        auto aNextScript = aEditEngine.GetScriptType({ 0, i, 0, i });
        if (aNextScript != aScript)
            maScriptChanges.emplace_back(aScript, i - 1);
        else if (i == maScriptText.getLength())
            maScriptChanges.emplace_back(aScript, i);
        aScript = aNextScript;
    }

If the style name is "標題 1" then when the last character '1' met (aNextScript
!= aScript) (in this case changed from LATIN to CJK), it would be left out
without pushing into maScriptChanges, i.e.
maScriptChanges.emplace_back(aScript, i); would not be executed.  That will
explain why we add a space after the number ("標題 1 ") could reveal all the
style name because maScriptChanges.emplace_back(aScript, i);  will be executed
in the last run of the loop.

I could add another if to make sure to push everything into maScriptChanges if
it was the last character, but I'm not sure if it would make the problem in
tdf#152737 back.

-- 
You are receiving this mail because:
You are the assignee for the bug.