https://bugs.documentfoundation.org/show_bug.cgi?id=152903

Miklos Vajna <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Regression By|Miklos Vajna                |
             Status|NEW                         |NEEDINFO
           Keywords|regression                  |implementationError

--- Comment #14 from Miklos Vajna <[email protected]> ---
My understanding is that the following happened:

- f21d2b48bd68424a96aa6cd5572e368208378291 (tdf#121723 vcl: leave popup mode on
focus loss of toplevel windows, 2018-11-26): see bug 121723, once we lost
focus, there was a leftover menu item that I fixed

- d4ed266849b558b041acb740a18bd81fa39bc582 (tdf#133350 vcl focus loss: fix
unwanted cancel of non-menu popup, 2021-03-29): 3 years later, see bug 133350,
it was claimed that this change cancelling popups is not wanted in general, so
I restricted the original change to menu items

- now this bug claims that the more broad canceling that was there between
2018-11-26 and 2021-03-29 (but not before, not after) is wanted.

I would claim that this is not a regression, since the wanted behavior had bad
side-effects (see bug 133350).

If there is an agreement regarding if the behavior in bug 133350 or this bug is
wanted, it's easy to act (either do nothing, or revert that oneliner change.
I'm happy with either of these, as long as menus get cancelled on focus loss.

Colin: could you please talk to [email protected] and reach an agreement on
the wanted behavior? We certainly don't want to flip-flop on this further.
Thanks.

Adjusting keywords accordingly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to